loading status messages are not handled/sent to the application + patch

[GoogleCodeExporter]

What steps will reproduce the problem?
1. load a page 

What is the expected output? What do you see instead?
loading status messages should pass to OnStatusMessage so the application
could display them

What version of the product are you using? On what operating system?
win32

Please provide any additional information below.
please take a look at my attached patch 

Original issue reported on code.google.com by revenc...@ptc.com on 6 Feb 2014 at 3:00

Attachments:

• loadStatus.patch

[GoogleCodeExporter]

Thanks for the patch. Some comments:

1. Line 19:

+ base::string16 CefBrowserHostImpl::GetLoadingStatusText();
+
+  virtual void NavigationStateChanged(const content::WebContents* source,
+                                      unsigned changed_flags) OVERRIDE;

Helper methods go near in the 'private' class section. Overloaded method should 
follow the same order as the declaration in the parent class. The same order 
should be followed in the .cc file.

Also, incorrect indentation.

2. Line 22:

+ base::string16 CefBrowserHostImpl::GetLoadingStatusText()  {

When copying code from somewhere else in Chromium you should mention the source 
in a comment (in this case chrome/browser/ui/tab_contents/core_tab_helper.cc).

3. Line 88:

+
+    if (client_.get()) {
+    CefRefPtr<CefDisplayHandler> handler = client_->GetDisplayHandler();
+    if (handler.get())
+      handler->OnStatusMessage(this, GetLoadingStatusText());
+  }
+  

Incorrect indentation.

Original comment by magreenb...@gmail.com on 7 Feb 2014 at 9:46

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

CEF is transitioning from Google Code to Bitbucket project hosting. If you 
would like to continue receiving notifications on this issue please add 
yourself as a Watcher at the new location: 
https://bitbucket.org/chromiumembedded/cef/issue/1193

Original comment by magreenb...@gmail.com on 14 Mar 2015 at 3:29