zhangqd / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 1 forks source link

Enable CefBrowserHost::WasHidden(bool) even for windowed browsers #1232

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.
There's no point in a multi-process architecture, if every application is 
supposed to have only one browser instance. And it's not possible even for a 
windowed browser to discover by itself that it's not visible.
Make available CefBrowserHost::WasHidden(bool) even for windowed browsers. It's 
important to reduce resource usage of that instance when it's not active (as 
judged by client applications). All it takes, is commenting lines 914 - 917 in 
browser_host_impl.cc:
914  if (!IsWindowRenderingDisabled()) {
915    NOTREACHED() << "Window rendering is not disabled";
916    return;
917  }

It can't break any code. 

Original issue reported on code.google.com by elenabaj...@gmail.com on 16 Mar 2014 at 5:27

GoogleCodeExporter commented 9 years ago
On Windows and Linux the underlying browser window handle is notified when 
window visibility changes. On Mac there is now a 
CefBrowserHost::SetWindowVisibility method. See issue #1301.

Original comment by magreenb...@gmail.com on 2 Jul 2014 at 11:10