search

zhangqd / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
0 stars 1 forks source link

OSRTest popup-related tests failing with Chromium revision 261035 #1245

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Run cef_unittests.exe --gtest_filter=OSRTest.PopupScrollInside

What is the expected output? What do you see instead?
Test should succeed, instead if fails with the following output:

os_rendering_unittest.cc(766): error: Value of: CefRect(1, 1, 
kExpandedSelectRect.width - 3, kExpandedSelectRect.height - 2)
  Actual: 24-byte object <D8-38 CC-00 01-00 00-00 01-00 00-00 4E-00 00-00 40-01 00-00 00-00 00-00>
Expected: dirtyRects[0]
Which is: 24-byte object <D8-38 CC-00 3E-00 00-00 11-00 00-00 11-00 00-00 1E-01 
00-00 00-00 00-00>

Please use labels and text to provide additional information.
The actual result equates to {x=62, y=17, w=17, h=286}, which is the scroll bar 
region of the popup. It appears that the popup's scroll bar is being repainted 
but not the popup content region itself. This can be manually verified as 
follows:

1. Run cefclient.exe --off-screen-rendering-enabled --url=http://tests/osr_test
2. Resize the window to 600x400.
3. Click on the select list to display it and scroll with the middle mouse 
button.
4. Notice that the elements in the content region are only repainted when you 
mouse over them.

Original issue reported on code.google.com by magreenb...@gmail.com on 3 Apr 2014 at 10:18

GoogleCodeExporter commented 9 years ago 
OSR popup-related tests are also failing on OS X 10.9.2:

Note: Google Test filter = OSRTest.Popup*
[==========] Running 8 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 8 tests from OSRTest
[ RUN      ] OSRTest.PopupPaint
[       OK ] OSRTest.PopupPaint (1149 ms)
[ RUN      ] OSRTest.PopupShow
[       OK ] OSRTest.PopupShow (336 ms)
[ RUN      ] OSRTest.PopupSize
[       OK ] OSRTest.PopupSize (334 ms)
[ RUN      ] OSRTest.PopupHideOnBlur
ASSERTION FAILED: focused()
../../third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp(334) : 
virtual bool WebCore::HTMLFormControlElement::shouldHaveFocusAppearance() const
1   0x5ce63b3 WebCore::HTMLFormControlElement::shouldHaveFocusAppearance() const
2   0x6bd4c7c WebCore::RenderTheme::isFocused(WebCore::RenderObject const*) 
const
3   0x6bdf6a5 WebCore::RenderThemeChromiumMac::updateFocusedState(NSCell*, 
WebCore::RenderObject const*)
4   0x6bdec82 
WebCore::RenderThemeChromiumMac::setPopupButtonCellState(WebCore::RenderObject 
const*, WebCore::IntRect const&)
5   0x6bdea04 
WebCore::RenderThemeChromiumMac::adjustRepaintRect(WebCore::RenderObject 
const*, WebCore::IntRect&)
6   0x6954b72 WebCore::RenderBlock::addVisualOverflowFromTheme()
7   0x695496b WebCore::RenderBlock::computeOverflow(WebCore::LayoutUnit, bool)
8   0x6a42e08 WebCore::RenderFlexibleBox::layoutBlock(bool)
9   0x6952cd4 WebCore::RenderBlock::layout()
10  0x6a80679 WebCore::RenderObject::layoutIfNeeded()
11  0x69c68e4 WebCore::RenderBlockFlow::layoutInlineChildren(bool, 
WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::LayoutUnit)
12  0x69ae73c WebCore::RenderBlockFlow::layoutBlockFlow(bool, 
WebCore::LayoutUnit&, WebCore::SubtreeLayoutScope&)
13  0x699e08e WebCore::RenderBlockFlow::layoutBlock(bool)
14  0x6952cd4 WebCore::RenderBlock::layout()
15  0x699eff6 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox*, 
WebCore::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
16  0x69a41ab WebCore::RenderBlockFlow::layoutBlockChildren(bool, 
WebCore::LayoutUnit&, WebCore::SubtreeLayoutScope&, WebCore::LayoutUnit, 
WebCore::LayoutUnit)
17  0x69ae79d WebCore::RenderBlockFlow::layoutBlockFlow(bool, 
WebCore::LayoutUnit&, WebCore::SubtreeLayoutScope&)
18  0x699e08e WebCore::RenderBlockFlow::layoutBlock(bool)
19  0x6952cd4 WebCore::RenderBlock::layout()
20  0x699eff6 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox*, 
WebCore::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
21  0x69a41ab WebCore::RenderBlockFlow::layoutBlockChildren(bool, 
WebCore::LayoutUnit&, WebCore::SubtreeLayoutScope&, WebCore::LayoutUnit, 
WebCore::LayoutUnit)
22  0x69ae79d WebCore::RenderBlockFlow::layoutBlockFlow(bool, 
WebCore::LayoutUnit&, WebCore::SubtreeLayoutScope&)
23  0x699e08e WebCore::RenderBlockFlow::layoutBlock(bool)
24  0x6952cd4 WebCore::RenderBlock::layout()
25  0x699eff6 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox*, 
WebCore::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&)
26  0x69a41ab WebCore::RenderBlockFlow::layoutBlockChildren(bool, 
WebCore::LayoutUnit&, WebCore::SubtreeLayoutScope&, WebCore::LayoutUnit, 
WebCore::LayoutUnit)
27  0x69ae79d WebCore::RenderBlockFlow::layoutBlockFlow(bool, 
WebCore::LayoutUnit&, WebCore::SubtreeLayoutScope&)
28  0x699e08e WebCore::RenderBlockFlow::layoutBlock(bool)
29  0x6952cd4 WebCore::RenderBlock::layout()
30  0x6c0499c WebCore::RenderView::layoutContent()
31  0x6c05007 WebCore::RenderView::layout()
../../cef/tests/unittests/os_rendering_unittest.cc:946: Failure
Value of: handler->succeeded()
  Actual: false
Expected: true
[  FAILED  ] OSRTest.PopupHideOnBlur (5001 ms)
[ RUN      ] OSRTest.PopupHideOnClick
[       OK ] OSRTest.PopupHideOnClick (353 ms)
[ RUN      ] OSRTest.PopupHideOnScroll
../../cef/tests/unittests/os_rendering_unittest.cc:948: Failure
Value of: handler->succeeded()
  Actual: false
Expected: true
[  FAILED  ] OSRTest.PopupHideOnScroll (5002 ms)
[ RUN      ] OSRTest.PopupHideOnEsc
../../cef/tests/unittests/os_rendering_unittest.cc:949: Failure
Value of: handler->succeeded()
  Actual: false
Expected: true
[  FAILED  ] OSRTest.PopupHideOnEsc (5001 ms)
[ RUN      ] OSRTest.PopupScrollInside
../../cef/tests/unittests/os_rendering_unittest.cc:772: Failure
Value of: CefRect(1, 0, kExpandedSelectRect.width - 3, 
kExpandedSelectRect.height - 1)
  Actual: 24-byte object <94-14 03-01 01-00 00-00 00-00 00-00 4D-00 00-00 05-01 00-00 00-00 00-00>
Expected: dirtyRects[0]
Which is: 24-byte object <94-14 03-01 3F-00 00-00 00-00 00-00 0F-00 00-00 04-01 
00-00 00-00 00-00>
[  FAILED  ] OSRTest.PopupScrollInside (1293 ms)
[----------] 8 tests from OSRTest (18469 ms total)

[----------] Global test environment tear-down
[==========] 8 tests from 1 test case ran. (18469 ms total)
[  PASSED  ] 4 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] OSRTest.PopupHideOnBlur
[  FAILED  ] OSRTest.PopupHideOnScroll
[  FAILED  ] OSRTest.PopupHideOnEsc
[  FAILED  ] OSRTest.PopupScrollInside

 4 FAILED TESTS

Original comment by magreenb...@gmail.com on 4 Apr 2014 at 4:29

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 4 Apr 2014 at 7:28

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 24 Apr 2014 at 5:47

GoogleCodeExporter commented 9 years ago 
https://bitbucket.org/chromiumembedded/branches-1916-cef3/pull-request/1/

Not sure if the pull requests could be applied, so - here is the patch:
https://bitbucket.org/api/2.0/repositories/chromiumembedded/branches-1916-cef3/p
atch/irosca/branches-1916-cef3%3A5bd58c467600..e13421c0cfd8

Original comment by iohan...@gmail.com on 23 May 2014 at 9:34

GoogleCodeExporter commented 9 years ago 
I added to the pull request build break fixes for Mac 64 and Linux:
https://bitbucket.org/api/2.0/repositories/chromiumembedded/branches-1916-cef3/p
ullrequests/1/patch

Original comment by iohan...@gmail.com on 24 May 2014 at 9:31

GoogleCodeExporter commented 9 years ago 
Another build break potential fix on linux trunk, release only: 
https://bitbucket.org/api/2.0/repositories/chromiumembedded/trunk-cef3/pullreque
sts/1/patch

Original comment by iohan...@gmail.com on 24 May 2014 at 10:13

GoogleCodeExporter commented 9 years ago 
@comments#4-6: Thanks, fixed in 1916 branch revision 1715 and trunk revision 
1716.

Original comment by magreenb...@gmail.com on 30 May 2014 at 7:30

GoogleCodeExporter commented 9 years ago 
Added in trunk revision 1751.

Original comment by magreenb...@gmail.com on 30 Jun 2014 at 10:33