search

zhangqianhui / Conditional-GAN

Tensorflow implementation for Conditional Convolutional Adversarial Networks.
MIT License
218 stars 83 forks source link

Why hardcoded constants? #8

Open constfilin opened 6 years ago

constfilin commented 6 years ago

On this line : https://github.com/zhangqianhui/Conditional-GAN/blob/1b4d7ea9578653b349ae5fbbd0ab4840a62578b4/model_mnist.py#L170 instead of 7*7*2*64 there should be c1*c1*2*self.batch_size.

Otherwise, why does this create variables and then neglects to use them?

zhangqianhui commented 5 years ago

thanks

constfilin commented 5 years ago

JFYI: please see my code based on your conditional GAN.