search

zhangtaii / react-native-google-place-picker

React Native Wrapper of Google Place Picker for iOS + Android.
MIT License
185 stars 54 forks source link

Android Build Failure (with fix) #25

Closed jakewtaylor closed 6 years ago

jakewtaylor commented 7 years ago

I got a build error when following the install steps for android:

[...]/node_modules/react-native-google-place-picker/android/src/main/java/com/reactlibrary/RNGooglePlacePickerPackage.java:20: error: method does not override or implement a method from a supertype
    @Override
    ^
Package Version
react-native 0.47.2
react-native-google-place-picker 1.2.1

I've fixed it by simply removing the @Override in RNGooglePlacePickerPackage.java at line 20, which seems to be working fine. I would submit that change as a PR but I'm not confident enough that's a good fix, I don't know Java too well.

ryanrossiter commented 7 years ago

@jakewtaylor I think your solution works, at least one other project has done that to fix this issue: https://github.com/realm/realm-js/issues/1176

jakewtaylor commented 7 years ago

Looks like it's already been requested here: #28

jakewtaylor commented 6 years ago

Closing, fixed in https://github.com/zhangtaii/react-native-google-place-picker/pull/28