search

zhangxiaoming / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Compile warning: static string out-of-bounds access #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
On a fresh ChromiumOS checkout, a build following the directions at [ 
http://www.chromium.org/chromium-os/how-tos-and-troubleshooting/building-chromiu
m-browser ] gives the following warning:

CXX 
obj/third_party/pdfium/core/src/fpdfapi/fpdf_parser/fpdfapi.fpdf_parser_parser.o
../../third_party/pdfium/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp: 
In member function 'CPDF_Object* 
CPDF_SyntaxParser::GetObjectByStrict(CPDF_IndirectObjects*, FX_DWORD, FX_DWORD, 
PARSE_CONTEXT*)':
../../third_party/pdfium/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:238
9:92: warning: offset outside bounds of constant string
                 pDict->AddValue(CFX_ByteStringC(key.c_str() + 1, key.GetLength() - 1), pObj);

There is an in-progress CL to address this, but it seems to have gone stale: 
https://codereview.chromium.org/716103002

Original issue reported on code.google.com by isherman@chromium.org on 5 Feb 2015 at 2:46

GoogleCodeExporter commented 9 years ago 
Fixed in 
https://pdfium.googlesource.com/pdfium/+/ae4256f45df69bbfdf722a6ec17e1e851911ae4
e.

Original comment by jun_f...@foxitsoftware.com on 15 Apr 2015 at 7:03