JSMin exceptions can't be thrown in an ob callback

zhanjh / minify

Automatically exported from code.google.com/p/minify

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

JSMin exceptions can't be thrown in an ob callback #134

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Since JSMin may run in an output buffer callback, we should avoid buffer-
based functions like var_export/print_r:
http://code.google.com/p/minify/source/browse/tags/release_2.1.3/min/lib/
JSMin.php#149

Possible fixes:
* Put the problem string in a property of the exceptions.
* Just append the string AS-IS to the Exception message.

Original issue reported on code.google.com by mrclay....@gmail.com on 31 Aug 2009 at 4:33

GoogleCodeExporter commented 9 years ago

Fixed in R411

Original comment by mrclay....@gmail.com on 3 Feb 2011 at 10:49

Changed state: Verified