zhanjh / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

set_incude_path has no fail check #148

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In min/index.php you have this:

set_include_path($min_libPath . PATH_SEPARATOR . get_include_path());
require 'Minify.php';

There is no check for if set_include_path fails (in which case it will return 
false) - so if it does, 
minify will carry on processing regardless.

At the very least if it fails - minify should stop processing there, but would 
it not be more sensible 
(and indeed, more efficient) to just replace that (and other includes) with 
something like this?
require $min_libPath . 'Minify.php';

Original issue reported on code.google.com by mark.j.w...@gmail.com on 4 Dec 2009 at 12:26

GoogleCodeExporter commented 9 years ago
The next release will use autoloading, so no more requires at all. For your 
situation you'll have to manually add "lib" to your include_path, or use 
"php_value" 
instead of "php_admin_value" in your web config.
http://php.dzone.com/news/setincludepath-failing

Original comment by mrclay....@gmail.com on 8 Dec 2009 at 1:00