search

zhanjh / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

@charset declarations causing problems in webkit browsers #187

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Minify version: 2.1.4

What steps will reproduce the problem?
1. place combined css call in header

Expected output: that it doesn't break the design across all browsers

Actual output:  The design breaks in chrome and safari (webkit browsers)

The CSS is completely valid

Original issue reported on code.google.com by dreedena...@gmail.com on 25 Jul 2010 at 8:35

GoogleCodeExporter commented 9 years ago 
I can't help without knowing what CSS gets mangled.

Original comment by mrclay....@gmail.com on 26 Jul 2010 at 1:41

GoogleCodeExporter commented 9 years ago 
I had solved the same problem just in this moment. The problem was that one 
stylesheet contained @media and @charset tags.

Original comment by daniel.r...@gmail.com on 3 Aug 2010 at 7:14

GoogleCodeExporter commented 9 years ago 
I can also confirm that removing the @charset fixed it on mine too.. Now to 
find why combined  & minified javascript doesn't work!

Original comment by leasinga...@googlemail.com on 9 Sep 2010 at 11:00

GoogleCodeExporter commented 9 years ago 
Minify shouldn't be in the business of managing charsets, hence I'm inclined to 
have it strip all @charset declarations and assume the user is competent enough 
to manage getting all files in UTF-8 or another encoding of their choice. If 
not UTF-8, they can then change the charset header Minify sends on all requests:

$min_serveOptions['contentTypeCharset'] = 'myEncoding';

Original comment by mrclay....@gmail.com on 9 Sep 2010 at 3:52

GoogleCodeExporter commented 9 years ago

Original comment by mrclay....@gmail.com on 19 Sep 2010 at 4:48

GoogleCodeExporter commented 9 years ago 
r423 strips all @charsets in Minify_CSS

Original comment by mrclay....@gmail.com on 30 Sep 2010 at 4:35