zhanjh / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

W3C Validation #227

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
While this is rather trivial, have you thought of a way to create W3C valid 
markup?

Great work with this project and thank you for making it available!

Original issue reported on code.google.com by peter.p....@gmail.com on 14 Apr 2011 at 11:06

GoogleCodeExporter commented 9 years ago
Thanks! Can you be more specific? If you mean "fixing" markup sent through 
Minify_HTML, that's a task better suited for something like Tidy or components 
made for that purpose.

Original comment by mrclay....@gmail.com on 14 Apr 2011 at 1:38

GoogleCodeExporter commented 9 years ago
When running the W3C validation tool over my header markup, I receive markup 
errors due to the stylesheet link href. Here is a sample:

<link rel="stylesheet" type="text/css" media="screen" 
href="/lib/min/b=style&f=global/global_V1_20110412.css,index6.css,jquery.fancybo
x.css,widescreen3/fixedwidth5.css" />

This causes errors such as:
Error Line 21, Column 78: general entity "f" not defined and no default entity
Error Line 21, Column 79: reference to entity "f" for which no system 
identifier could be generated
Warning Line 38, Column 53: reference not terminated by REFC delimiter
[...]

This is rather trivial, I was just curious whether you had a solution for this 
issue (if you can call it that). Due the the dynamic nature of the website, I 
cannot use groups as it would pose too much of a hassle (site is large, has 
many sections, and as such, many section specific combinations of style sheets).

I attempted a mod rewrite approach, but could not get it to work:
# -- CSS/JS Minifier W3C Validator fix
RewriteBase /lib/min/
RewriteRule ^b_uri/(.*)/f_uri/(.*)$ index.php?b=$1&f=$2 [L]

the link was modified to this:
/lib/min/b_uri/style/f_uri/global/global_V1_20110412.css,index6.css,jquery.fancy
box.css,widescreen3/fixedwidth5.css

I would greatly appreciate any ideas.

Original comment by peter.p....@gmail.com on 14 Apr 2011 at 1:48

GoogleCodeExporter commented 9 years ago
The Builder (http://code.google.com/p/minify/wiki/BuilderApp ) actually outputs 
HTML that's properly escaped. If you write your own markup, it's up to you to 
HTML escape entities like "&".

I mention this in min/README:
http://code.google.com/p/minify/source/browse/branches/2.1.4/min/README.txt#54

Original comment by mrclay....@gmail.com on 14 Apr 2011 at 2:57