zhanwenchen / relaug

MIT License
0 stars 0 forks source link

Shape Bug in Graft #58

Closed zhanwenchen closed 1 year ago

zhanwenchen commented 1 year ago

🐛 Bug

To Reproduce

Steps to reproduce the behavior:

1. 1. 1.

Expected behavior

Environment

Please copy and paste the output from the environment collection script from PyTorch (or fill out the checklist below manually).

You can get the script and run it with:

wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py

Additional context

zhanwenchen commented 1 year ago

It's not because of the random seed.

zhanwenchen commented 1 year ago

Let's debug from the df side

zhanwenchen commented 1 year ago

Also, we are saving the result to the object.

zhanwenchen commented 1 year ago

Maybe it's because generator or distributed (in other words, cuda=0 in legion vs on lab)?

zhanwenchen commented 1 year ago

Maybe implement a singleton object for vgstats

zhanwenchen commented 1 year ago

There is now a problem of PIL images in the dataset.

zhanwenchen commented 1 year ago

Is there a reason why I didn't use the dataloader dataset for the stats. Is it because of the transforms?

zhanwenchen commented 1 year ago

The PIL images in the dataset didn't come from getitem of the graft augmented. It's not run() either.

zhanwenchen commented 1 year ago

Maybe need to deepcopy dataset because it's set to None? That's it!!!! Deepcopy in graftaugmenter worked!

zhanwenchen commented 1 year ago

Keep running to see if there's any more sample mismatch issue.

zhanwenchen commented 1 year ago

There was a NotImplementedError after 400 iterations. That was probably because the graftdataset had a commented out getitem for debugging purposes.

zhanwenchen commented 1 year ago

Closed by #50 #86