search

zhanxw / rvtests

Rare variant test software for next generation sequencing data
134 stars 43 forks source link

VT analytic #12

Open Rosadosa opened 7 years ago

Rosadosa commented 7 years ago

Hi Zhanxw,

thank you for your very valuable tool! I have a question regarding the Variable threshold analytic option. In the manual it is stated this option supports both binary and quantitative phenotypes. However when I try to run the analysis, a warning appears that the analytic option doesn't work on a binary phenotype, and all my values are "NA".

Is this merely a mistake in the manual, or is there something else going on?

Best, Roos

zhanxw commented 7 years ago

Thanks Roos. I can replicate the problem.

The VT analytic option should work. I will fix this bug.

zhanxw commented 7 years ago

From source code, https://github.com/zhanxw/rvtests/blob/master/src/Model.h#L2132, It looks like that I have not implemented the analytic VT method for binary trait. I plan to do it when I have more time.

learb commented 6 years ago

Hi Zhanxw,

thank you for this really valuable tool! I see you had in mind to implement analytic VT for binary trait, but I still get the error described here. Is this still an enhancement you are considering? do you have a work-around?

Thanks Lea