search

zhanxw / rvtests

Rare variant test software for next generation sequencing data
131 stars 41 forks source link

AF issue still not fixed in the April 14 version #17

Closed jielab closed 7 years ago

jielab commented 7 years ago

Dear Xiaowei:

I just sent an email to your GMAIL. I downloaded your new RVTESTS posted yesterday. For one imputed 5MB chunk, I run RVTESTS using the same command and the same data as before, but I still found negative values in the AF column. The score test based on the previous version of RVTESTS used 25247 seconds, but the new version took 59095 seconds. The wald test in the new version takes 31316 seconds.

Also, somehow the new version still shows “version: 20170228”.

So, can you please take a good look, to make sure that the AF issue is indeed resolved? It would be great if you change the version date to the release date so that we are sure that we are using the latest version.

Thank you & best regards, Jie screenshot1 screenshot2

zhanxw commented 7 years ago

The version tag indicates that it's not the April 14 version. But soon, I will deliver a new version. You will be able to verify it fixes this issue as well as issue #18.

jielab commented 7 years ago

It would be really great that you could put a fixed version online today, as soon as possible. I need to run some new analysis and report back to our group tomorrow morning!

best regards, Jie

zhanxw commented 7 years ago

Sorry for the confusion. I was referring to this release: https://github.com/zhanxw/rvtests/releases/tag/v2.0.4

This version should fix this issue. Thanks.