search

zhaocai / GoldenView.Vim

Always have a nice view for vim split windows!
http://zhaocai.github.io/GoldenView.Vim/
219 stars 14 forks source link

[fix] fixed error "using Float as a String" when system locale using comma as float separator #25

Open TKr opened 8 years ago

TKr commented 8 years ago

Mac OSX, phpstorm terminal vs system terminal

When LC_NUMERIC="C" let s:goldenview__golden_ratio = 1.618 end with error using Float as a String

When i set LC_NUMERIC="pl_PL.UTF-8" let s:goldenview__golden_ratio = 1.618 without problem.

After fix: When LC_NUMERIC="C" let l:golden_ratio_dot = str2float("1.618") /// 1 let l:golden_ratio_comma = str2float("1,618") /// 1,618 When LC_NUMERIC="pl_PL.UTF-8" let l:golden_ratio_dot = str2float("1.618") /// 1.618 let l:golden_ratio_comma = str2float("1,618") /// 1

Then let s:goldenview__golden_ratio = l:golden_ratio_xxxx and both without errors.

ReneFroger commented 8 years ago

Please try golden-ratio on Emacs instead.

dgilge commented 6 years ago

Same issue here.

E806: using Float as a String
E15: Invalid expression: 1.618

Are there plans to fix this?