zhaochenyang20 / TOFEL_words_reviewer

15 stars 6 forks source link

Homework Submission #28

Closed abmfy closed 2 years ago

abmfy commented 2 years ago

https://git.tsinghua.edu.cn/wangbw21/awrwordreviewer/

zhaochenyang20 commented 2 years ago

开源报告非常漂亮,值得表扬!

zhaochenyang20 commented 2 years ago
parser.add_argument('-r', '--random',
        dest='random', action='store_true',
        help='whether to randomly select the words; if unset, '
             'each word list will contain different words in order'
    )
    parser.add_argument('-s', '--sorted',
        dest='sorted', action='store_true',
        help='whether to sort the word list'
    )

此处有两个 store_true 的变量,虽然这么写可以运行,但是一般而言,我们对 store_true 的变量使用 --r 而非 -r,作为和一般变量的区别(否则你指定了参数却没有传入数值,看着很奇怪)

zhaochenyang20 commented 2 years ago

代码风格不错,整体注释详尽,可以再添加传入的接口注释,比如参考这份作业:https://git.tsinghua.edu.cn/lkm20/3.0-hw1/-/blob/master/wordTranslation.py

zhaochenyang20 commented 2 years ago

作为初学者,提出表扬!