search

zhaofengli / attic

Multi-tenant Nix Binary Cache
https://docs.attic.rs
Other
1.04k stars 79 forks source link

Log stream errors #137

Closed cole-h closed 5 months ago

cole-h commented 5 months ago

Closes https://github.com/zhaofengli/attic/issues/124.

Unless other knowledge comes to light, it appears that that was actually caused by an error in the actual stream of data itself -- I tested this by uploading something (with the storage backend as local), then manually messing with the database to change the remote_file and remote_file_id columns on the chunk table to point to some bogus (but valid-syntax) location in an S3 bucket. When trying to download, I would see errors from Nix but nothing from attic. Adding this print rectifies that.

zhaofengli commented 5 months ago

LGTM, thanks!

cole-h commented 3 months ago

FYI, it appears the issue this was fixing was reintroduced as part of the axum 0.7 update in https://github.com/zhaofengli/attic/pull/138 -- I've re-fixed it in https://github.com/zhaofengli/attic/pull/154