Integration with nvd when available

zhaofengli / colmena

A simple, stateless NixOS deployment tool

https://colmena.cli.rs

MIT License

1.27k stars 68 forks source link

Integration with nvd when available #130

Open RaitoBezarius opened 1 year ago

RaitoBezarius commented 1 year ago

I would like to use nvd (nix diff) to see the delta after an evaluation between the current system and the evaluated one.

It is useful for my local deployments where I do "interactive" upgrades and deployments.

What would be the way forward to send such a PR?

zhaofengli commented 1 year ago

This currently can be done as an activationScript that supports dry activation: https://github.com/zhaofengli/colmena/issues/128#issuecomment-1333791919. Adding an interactive step for confirmation can be tricky because of the parallellism Colmena has. Evaluation, build, and deployment of different nodes can be running at the same time.

RaitoBezarius commented 1 year ago

Tried it, thank you! It works great, but colors are broken it seems like? Would you be open to a small PR to document it or have a first-class support with deployment.contrib.useNVD = true; or something like this?