search

zhaohuabing / hugo-theme-cleanwhite

A clean, elegant blog theme for hugo
Apache License 2.0
730 stars 339 forks source link

[Question] post's background image is not responsive #81

Closed Dry8r3aD closed 4 years ago

Dry8r3aD commented 4 years ago

Hello, and thank you for your awesome theme! I'm loving it!

while customizing the blog, I found out that when the image of the post is larger than my resolution, it's cropped and seems like it's not responsive.

I'll show you the example (please forgive me for using Korean in the image. but I had to reproduce it with my actual posting) Situation: zoom-in as far as I can in my web browser

fixed_max

-> What I expected

notfixed_max

-> What i'm seeing

So my question is, is this intentional? I have found a solution to fix this, by setting background-image-size to "contain" from "cover", and I just wanted to know if this is a bug or intended code.

If you think it's a bug, I'll create a PR!

Thanks,

Dry8r3aD commented 4 years ago

while I was looking into this a bit more when the image's background is transparent, background-image-size value with "contain" looked nicer, and when the image's background is not transparent the "cover" value looked nicer.

So I guess this isn't an issue at all, and I would need to find a way to show transparent images without getting cropped.

I will close the issue. Thanks!