Re-architect the whole app.

zhaonian / Ureka-Lite

Ureka in native Android.

Apache License 2.0

1 stars 0 forks source link

Re-architect the whole app. #48

Open zhaonian opened 5 years ago

zhaonian commented 5 years ago

Goals:

the whole app will vastly rely on Dependency Injection using Dagger.
Kotlin Coroutines stable release, so it might be a better option for handling threading and concurrency than RxJava and RxKotlin.
for network only data source, do not use Repository pattern, viewmodel should be able to handle it.
for network data source that needed to be cached in DB, use the repository pattern.

DaviesX commented 5 years ago

Grpc client

On Thu, Sep 5, 2019, 8:27 PM Zhaonian Luan notifications@github.com wrote:

Goals:

the whole app will vastly rely on Dependency Injection using Dagger.

Kotlin Coroutines stable release, so it might be a better option for handling threading and concurrency than RxJava and RxKotlin.

for network only data source, do not use Repository pattern, viewmodel should be able to handle it.

for network data source that needed to be cached in DB, use the repository pattern.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zhaonian/Ureka-Lite/issues/48?email_source=notifications&email_token=ABT3B4MHC3GWI34JQWCN733QIHEZ7A5CNFSM4IUERP5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJWOWXQ, or mute the thread https://github.com/notifications/unsubscribe-auth/ABT3B4KWCJWYMFXNULV4MRDQIHEZ7ANCNFSM4IUERP5A .

zhaonian commented 5 years ago

@DaviesX yea sure.....only If you refactor the whole ureka backend to GRPC :)

DaviesX commented 5 years ago

Not whole. A lightweight unwrapper will do the trick.

On Fri, Sep 6, 2019, 1:29 PM Zhaonian Luan notifications@github.com wrote:

@DaviesX https://github.com/DaviesX yea sure.....only If you refactor the whole ureka backend to GRPC :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zhaonian/Ureka-Lite/issues/48?email_source=notifications&email_token=ABT3B4JBTDWEIIXWB2EXX5LQIK4T7A5CNFSM4IUERP5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6D7G3I#issuecomment-529003373, or mute the thread https://github.com/notifications/unsubscribe-auth/ABT3B4PJPD7AB4AJCKR6273QIK4T7ANCNFSM4IUERP5A .

zhaonian commented 5 years ago

https://recruitingdaily.com/wp-content/uploads/sites/6/2017/02/quote-talk-is-cheap-show-me-the-code-linus-torvalds-45-66-13-e1487242875427.jpg

zhaonian commented 5 years ago

@DaviesX actually, that would be very beneficial to use gRPC on Ureka because there are a lot of regressions due to client and server not being consistent with each other. you should do it :D