search

zhaopuming / quickfast

Automatically exported from code.google.com/p/quickfast
Other
1 stars 0 forks source link

Logger: Missing virtual destructor #48

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Missing virtual destructor.
File ./lib/Common/Logger.h

Class Logger has virtual methods, but does not have any destructor.

I have added line #16:

16       virtual ~Logger() {}; // olegh

Suggest you to include into lib code.

Original issue reported on code.google.com by khova...@gmail.com on 22 Apr 2010 at 1:21

GoogleCodeExporter commented 9 years ago 
Oh all right.    You are correct, if anyone ever deleted a pointer to a Logger 
bad 
things might happen, but no one should be deleting a pointer to a Logger.

I added the virtual destructor any way.  Thanks for keeping me honest.

Original comment by dale.wil...@gmail.com on 22 Apr 2010 at 3:12

GoogleCodeExporter commented 9 years ago 
Checked in as rev 393.

Original comment by dale.wil...@gmail.com on 22 Apr 2010 at 3:13