zhchsf / redis_cluster

A redis cluster ruby client gem
MIT License
20 stars 10 forks source link

Catch exception connected with disabled Redis configuration option #2

Closed evgeny-s closed 7 years ago

evgeny-s commented 7 years ago

Hello.

Would be great to add handling of cluster disabled option of Redis instance here: https://github.com/zhchsf/redis_cluster/blob/master/lib/redis_cluster/client.rb#L52

Because if you have not configure your Redis to cluster, there is not obvious error here.

Let me know if you need more explanations.

Thank you for your work!

zhchsf commented 7 years ago

Sorry see you issue yesterday.

Do you mean this? https://github.com/zhchsf/redis_cluster/blob/issue2/lib/redis_cluster/client.rb#L64

evgeny-s commented 7 years ago

Yes I had this issue but I didn't get proper error message.

zhchsf commented 7 years ago

If raise error for one node, It has some problems when app is running and you delete node from cluster. So now it will raise error only when cluster instance initialize . The codes is pending merged.

zhchsf commented 7 years ago

merged!

evgeny-s commented 7 years ago

ok. Thank you.