zhchsf / redis_cluster

A redis cluster ruby client gem
MIT License
20 stars 10 forks source link

Support for redis-rb 4+ #9

Open brandur opened 6 years ago

brandur commented 6 years ago

Nice work on this one. Thanks!

redis-rb now has version 4 and above in their gem and this gem restricts by coupling to ~> 3.2. I assume that's mostly unintentional and that it might be possible to loosen this constraint a bit.

redis-rb 4.0's major change seems to be that support for Ruby < 2.2.2 has been dropped; aside from that it mostly contains a few removals of deprecated methods. With any luck, it should be pretty easy to support.

Unrelatedly, are you (or do you know of anyone else) using this in a production environment? This seems to be the best-supported Redis Cluster gem out there, but even so it doesn't seem to be seeing all that much activity (although maybe that's just because it's so stable ;).

zhchsf commented 6 years ago

I will take some time to make it compatible with redis-rb 4.x. Thanks!

I don't know whether other people using it in a production. But some people submitted several issues, and issues has been finished.

I work in a small company, no much resources and traffics, and only use some basic commands. So Its stability is not fully verified. If you want to use, i think you should do enough testing.

brandur commented 6 years ago

I work in a small company, no much resources and traffics, and only use some basic commands. So Its stability is not fully verified. If you want to use, i think you should do enough testing.

Understood. Thanks for replying!