Edit Mix Multpx Parameter

[GoogleCodeExporter]

-Which board (stock / gruvin9x / sky9x / Taranis) are you using?

Taranis

-What is your openTx FW version?

r2834

-What is your openTx EEPROM version?

215

-What steps will reproduce the problem?

When editing a Single-line or Multi-line mix in the MIXER EDIT MIX menu, user 
can specify for each line, a Multpx parameter of either Add, Multipl, or 
Replace.

This feature should be disabled only for the first line of either single line 
or multi-line mixes, as the Multpx parameter on the first line has no function.

-What is the expected output? What do you see instead?

This ability is only confusing when using the 'Replace' (e.g., :=) parameter. 
Having the ability to enter the parameter on the first line is both unnecessary 
and confusing. User may not realize that the computation process takes place 
from bottom to top, not top to bottom.

- Please provide any additional information below.

none.

Original issue reported on code.google.com by barry.m....@gmail.com on 20 Nov 2013 at 7:07

[GoogleCodeExporter]

Hmm not very favorable to that. Lines can be moved around, and settings 
changing on their own just because you go over the first slot of a channel 
wouldn't be fun. 

Original comment by bernet.a...@gmail.com on 21 Nov 2013 at 11:18

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

This topic is about making the firmware more intuitive to the user and not 
about making it more functional from the programmer's perspective.

Original comment by barry.m....@gmail.com on 21 Nov 2013 at 6:02

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

And my comment was also directed to the danger for a user to make a mistake 
because of it. Not at the programming side of it. 

Say you have 3 lines on a channel. One has type Replace. You want to change the 
order of lines, and while you move them around that Replace line ends up in 
first position before being brought somewhere else again. If the first line 
only allowed Add this line would be modified without the user being aware of 
it. 

If an user doesn not understand that Replace or Multiply are useless on the 
first line, then he likely needs to work a bit more as he likely doesn't really 
get what they're used for :)

Original comment by bernet.a...@gmail.com on 22 Nov 2013 at 12:08

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Maybe I misunderstand the function of the first line?  Is the Multipx parameter 
used in the first line as the operator of the mix result to the Source?

I thought that the first line's Multipx parameter has no function, as for the 
line mix, the 'Add', 'Multiply', or 'Replace' operators always come from the 
line below.

For a 3-line mix, the order for the default 'Add' line also makes a difference 
if Multiply or Replace are also used.  So, if you swap Line3 with Line2 and use 
dis-similar operators, the result won't be the same, even if Line1 remains the 
same position. 

Source * (Line1 * (Line2 + Line3))
Source * (Line1 + (Line2 * Line3))

Unless I have misunderstood the first lines Multipx parameter, might be better 
understood by user if the parameter was removed from the EDIT MIX menu and 
placed on the MIXER and channel assignment menu.

Original comment by barry.m....@gmail.com on 22 Nov 2013 at 6:49

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Well, using the simulator for a single line mix. Changing the Multipx parameter 
from the default 'Add', gives mixed results:

'Add' or 'Replace' produce the same result (result = Source * Mix). 

'Multiply' disables the mix or results in a constant value of 0%.

When you think about it, 'Replace' has no meaningful application to the Source.

Original comment by barry.m....@gmail.com on 22 Nov 2013 at 7:45

[GoogleCodeExporter]

Yep, that's how it works. 
As calculations are done from top down and the fist line has nothing above it, 
replacing nothing does the same as adding to nothing, and multiplying nothing 
always equals 0 :)

Same logic everywhere and no hidden behaviors, that's openTx's way of working 
and strength :)

Original comment by bernet.a...@gmail.com on 25 Nov 2013 at 3:55

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

OK, thanks for the explaination.  I think I finally got it.  I've attached a 
flow chart of the mixer.

Original comment by barry.m....@gmail.com on 25 Nov 2013 at 7:03

Attachments:

• mixer.jpg

[GoogleCodeExporter]

It would be like upside down.

Mixer line 1 (top) is first in the calculation line. Then the 2nd under it, 
then the 3rd etc. 

Original comment by bernet.a...@gmail.com on 25 Nov 2013 at 8:54

• Changed state: WontFix