zhen-zen / YogaSMC

ACPI driver for OEM hardware.
GNU General Public License v2.0
237 stars 25 forks source link

Don't read fan on thinkpad L560 #178

Open mbarbierato opened 1 year ago

mbarbierato commented 1 year ago

Hi zen i have a problem with fan on lenovo L560, this is ioreg and sysreport MacBookPro.ioreg.zip SysReport.zip

zhen-zen commented 1 year ago

I didn't notice anything missing. Is the fan reading available in Windows or Linux?

mbarbierato commented 1 year ago

Yes it's avaiable Screenshot from 2022-10-22 12-39-20

zhen-zen commented 1 year ago

It's a bit weird, only 1 fan presents and the EC layout is expected so there shouldn't be any difference with other models. Can you try ioio -s ThinkVPC ReadECOffset 0x84 ioio -s ThinkVPC ReadECOffset 0x85 and check kernel log output sudo dmesg | grep YSMC? Meanwhile, is fan speed reading available from SMC?

mbarbierato commented 1 year ago

Hi Zhen, result of offset 0x84 is "ioio: setting property 'ThinkVPC:ReadECOffset' as number to 132 (0x84)" result of offset 0x85 is "ioio: setting property 'ThinkVPC:ReadECOffset' as number to 133 (0x85)" the kernel output log is [ 1.808205]: YSMC - Info: HKEY::ThinkVPC updateAdaptiveKBD 0 fffffffb [ 1.849034]: YSMC - Info: HKEY::ThinkVPC KeyboardLocale evaluation failed [ 35.870599]: 2 duplicate reports for Sandbox: icdd(449) allow mach-lookup com.apple.FSEventsSandbox: icdd(449) allow file-read-data /Library/Image Capture/Devices1 duplicate report for Sandbox: icdd(449) allow file-read-data /Library/Image Capture/DevicesSandbox: ctkd(470) deny(1) mach-lookup com.apple.CoreServices.coreservicesdsuccessfully parsed 1/4 entries for file MacBookPro.ioreg.zipSandbox: ctkd(470) deny(1) mach-lookup com.apple.DiskArbitration.diskarbitrationdSandbox apply: heard[439] Sandbox apply: fileproviderd[421] 3 duplicate reports for Sandbox: ctkd(470) deny(1) mach-lookup com.apple.DiskArbitration.diskarbitrationdSandbox: icdd(449) allow network-outbound /private/var/run/mDNSResponder9 duplicate reports for Sandbox: icdd(449) allow network-outbound /private/var/run/mDNSResponderSandbox: icdd(449) allow mach-lookup com.apple.DiskArbitration.diskarbitrationd2 duplicate reports for Sandbox: icdd(449) allow mach-lookup com.apple.DiskArbitration.diskarbitrationdSandbox: icdd(449) allow mach-lookup com.apple.coreservices.launchservicesdYSMC - Info: ThinkVPC::YogaSMCUserClient registerNotificationPort subscribed

thanks in advance

zhen-zen commented 1 year ago

There's no expected output from the commands above. Probably something's wrong with ACPI. Can you try the commands again and then check sudo dmesg | grep ACPI?

mbarbierato commented 1 year ago

This is the output of command [ 0.667349]: ACPI: ACPI: RSDP 0x00000000B7FFE014 000024 (v02 LENOVO)RSDP 0x00000000B7FFE014 000024 (v02 LENOVO) [ 0.668817]: ACPI: ACPI: XSDT 0x00000000B7F8A000 00012C (v01 LENOVO TP-N1H 00000000 PTEC 00000002)XSDT 0x00000000B7F8A000 00012C (v01 LENOVO TP-N1H 00000000 PTEC 00000002) [ 0.671236]: ACPI: ACPI: FACP 0x00000000B7FF5000 0000F4 (v05 LENOVO TP-N1H 00001530 PTEC 00000002)FACP 0x00000000B7FF5000 0000F4 (v05 LENOVO TP-N1H 00001530 PTEC 00000002) [ 0.693466]: ACPI: ACPI: DSDT 0x00000000B7FCB000 024327 (v02 LENOVO SKL 00000000 INTL 20141107)DSDT 0x00000000B7FCB000 024327 (v02 LENOVO SKL 00000000 INTL 20141107) [ 0.695857]: ACPI: ACPI: FACS 0x00000000B7F93000 000040FACS 0x00000000B7F93000 000040calling mpo_policy_init for AMFI [ 1.241949]: ACPI: ACPI: UEFI 0x00000000B7FA9000 000042 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)UEFI 0x00000000B7FA9000 000042 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.255907]: ACPI: ACPI: SSDT 0x00000000B7FF7000 005366 (v02 LENOVO SaSsdt 00003000 INTL 20141107)SSDT 0x00000000B7FF7000 005366 (v02 LENOVO SaSsdt 00003000 INTL 20141107) [ 1.268613]: ACPI: ACPI: SSDT 0x00000000B7FF6000 0005C5 (v02 LENOVO PerfTune 00001000 INTL 20141107)SSDT 0x00000000B7FF6000 0005C5 (v02 LENOVO PerfTune 00001000 INTL 20141107) [ 1.281169]: ACPI: ACPI: HPET 0x00000000B7FF4000 000038 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)HPET 0x00000000B7FF4000 000038 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.293772]: ACPI: ACPI: LPIT 0x00000000B7FF3000 000094 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)LPIT 0x00000000B7FF3000 000094 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.306405]: ACPI: ACPI: APIC 0x00000000B7FF2000 0000BC (v03 LENOVO TP-N1H 00001530 PTEC 00000002)APIC 0x00000000B7FF2000 0000BC (v03 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.319022]: ACPI: ACPI: MCFG 0x00000000B7FF1000 00003C (v01 LENOVO TP-N1H 00001530 PTEC 00000002)MCFG 0x00000000B7FF1000 00003C (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.331559]: ACPI: ACPI: WDAT 0x00000000B7FF0000 000134 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)WDAT 0x00000000B7FF0000 000134 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.344017]: ACPI: ACPI: SSDT 0x00000000B7FCA000 000248 (v02 LENOVO sensrhub 00000000 INTL 20141107)SSDT 0x00000000B7FCA000 000248 (v02 LENOVO sensrhub 00000000 INTL 20141107) [ 1.356504]: ACPI: ACPI: SSDT 0x00000000B7FC9000 0002D4 (v01 LENOVO EInkApp 00000000 INTL 20141107)SSDT 0x00000000B7FC9000 0002D4 (v01 LENOVO EInkApp 00000000 INTL 20141107) [ 1.368953]: ACPI: ACPI: SSDT 0x00000000B7FC8000 00019A (v02 LENOVO Sata0Ide 00001000 INTL 20141107)SSDT 0x00000000B7FC8000 00019A (v02 LENOVO Sata0Ide 00001000 INTL 20141107) [ 1.381453]: ACPI: ACPI: SSDT 0x00000000B7FC7000 000B49 (v02 LENOVO UsbCTabl 00001000 INTL 20141107)SSDT 0x00000000B7FC7000 000B49 (v02 LENOVO UsbCTabl 00001000 INTL 20141107) [ 1.393741]: ACPI: ACPI: SSDT 0x00000000B7FC6000 000120 (v02 LENOVO zpodd 00001000 INTL 20141107)SSDT 0x00000000B7FC6000 000120 (v02 LENOVO zpodd 00001000 INTL 20141107) [ 1.405878]: ACPI: ACPI: DBGP 0x00000000B7FC5000 000034 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)DBGP 0x00000000B7FC5000 000034 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.417920]: ACPI: ACPI: DBG2 0x00000000B7FC4000 000054 (v00 LENOVO TP-N1H 00001530 PTEC 00000002)DBG2 0x00000000B7FC4000 000054 (v00 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.429926]: ACPI: ACPI: SSDT 0x00000000B7FC3000 00075F (v02 LENOVO xh_rvp07 00000000 INTL 20141107)SSDT 0x00000000B7FC3000 00075F (v02 LENOVO xh_rvp07 00000000 INTL 20141107) [ 1.441531]: ACPI: ACPI: BOOT 0x00000000B7FC2000 000028 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)BOOT 0x00000000B7FC2000 000028 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.452879]: ACPI: ACPI: BATB 0x00000000B7FC1000 00004A (v02 LENOVO TP-N1H 00001530 PTEC 00000002)BATB 0x00000000B7FC1000 00004A (v02 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.464060]: ACPI: ACPI: SLIC 0x00000000B7FC0000 000176 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)SLIC 0x00000000B7FC0000 000176 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.475286]: ACPI: ACPI: SSDT 0x00000000B7FBF000 000E73 (v02 LENOVO CpuSsdt 00003000 INTL 20141107)SSDT 0x00000000B7FBF000 000E73 (v02 LENOVO CpuSsdt 00003000 INTL 20141107) [ 1.486307]: ACPI: ACPI: SSDT 0x00000000B7FFD000 000403 (v02 LENOVO CtdpB 00001000 INTL 20141107)SSDT 0x00000000B7FFD000 000403 (v02 LENOVO CtdpB 00001000 INTL 20141107) [ 1.497197]: ACPI: ACPI: MSDM 0x00000000B7FBD000 000055 (v03 LENOVO TP-N1H 00001530 PTEC 00000002)MSDM 0x00000000B7FBD000 000055 (v03 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.508077]: ACPI: ACPI: DMAR 0x00000000B7FBC000 0000A8 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)DMAR 0x00000000B7FBC000 0000A8 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.518612]: ACPI: ACPI: ASF! 0x00000000B7FBB000 0000A5 (v32 LENOVO TP-N1H 00001530 PTEC 00000002)ASF! 0x00000000B7FBB000 0000A5 (v32 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.528777]: ACPI: ACPI: FPDT 0x00000000B7FBA000 000044 (v01 LENOVO TP-N1H 00001530 PTEC 00000002)FPDT 0x00000000B7FBA000 000044 (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.538631]: ACPI: ACPI: UEFI 0x00000000B7F91000 00012A (v01 LENOVO TP-N1H 00001530 PTEC 00000002)UEFI 0x00000000B7F91000 00012A (v01 LENOVO TP-N1H 00001530 PTEC 00000002) [ 1.548098]: ACPI: ACPI: SSDT 0x00000000B7F90000 000132 (v02 ACDT SsdtEC 00001000 INTL 20200528)SSDT 0x00000000B7F90000 000132 (v02 ACDT SsdtEC 00001000 INTL 20200528) [ 1.557258]: ACPI: ACPI: SSDT 0x00000000B7F8F000 00013D (v02 hack ECRW 00000000 INTL 20180427)SSDT 0x00000000B7F8F000 00013D (v02 hack ECRW 00000000 INTL 20180427) [ 1.566091]: ACPI: ACPI: SSDT 0x00000000B7F8E000 000199 (v02 hack Think 00000000 INTL 20200925)SSDT 0x00000000B7F8E000 000199 (v02 hack Think 00000000 INTL 20200925) [ 1.574656]: ACPI: ACPI: SSDT 0x00000000B7F8D000 000456 (v02 ACDT PNLF 00000000 INTL 20200925)SSDT 0x00000000B7F8D000 000456 (v02 ACDT PNLF 00000000 INTL 20200925) [ 1.582777]: ACPI: ACPI: SSDT 0x00000000B7F8C000 000047 (v02 CORP HPET 00000000 INTL 20200925)SSDT 0x00000000B7F8C000 000047 (v02 CORP HPET 00000000 INTL 20200925) [ 1.590652]: ACPI: ACPI: SSDT 0x00000000B7F8B000 000384 (v02 ACDT CpuPlug 00003000 INTL 20200528)SSDT 0x00000000B7F8B000 000384 (v02 ACDT CpuPlug 00003000 INTL 20200528) [ 1.660287]: ACPI: ACPI: 17 ACPI AML tables successfully acquired and loaded17 ACPI AML tables successfully acquired and loaded [ 1.676781]: AppleACPICPU: ProcessorId=1 LocalApicId=0 Enabled [ 1.682590]: AppleACPICPU: ProcessorId=2 LocalApicId=2 Enabled [ 1.689047]: AppleACPICPU: ProcessorId=3 LocalApicId=1 Enabled [ 1.694140]: AppleACPICPU: ProcessorId=4 LocalApicId=3 Enabled [ 1.698869]: AppleACPICPU: ProcessorId=5 LocalApicId=255 Disabled [ 1.703567]: AppleACPICPU: ProcessorId=6 LocalApicId=255 Disabled [ 1.708151]: AppleACPICPU: ProcessorId=7 LocalApicId=255 Disabled [ 1.712687]: AppleACPICPU: ProcessorId=8 LocalApicId=255 Disabled [ 1.734894]: ACPI: ACPI: Executed 27 blocks of module-level executable AML codeExecuted 27 blocks of module-level executable AML code [ 1.768511]: ACPI: sleep states S3 S4 S5 [ 1.773648]: ACPI: cannot translate ACPI object 14 [ 1.773658]: ACPI: cannot translate ACPI object 14 [ 1.773667]: ACPI: cannot translate ACPI object 14 [ 1.774086]: ACPI: cannot translate ACPI object 14 [ 1.774095]: ACPI: cannot translate ACPI object 14 [ 1.774101]: ACPI: cannot translate ACPI object 14 [ 1.774474]: ACPI: cannot translate ACPI object 14 [ 1.774482]: ACPI: cannot translate ACPI object 14 [ 1.774489]: ACPI: cannot translate ACPI object 14 [ 1.804425]: AppleACPILid:0x100000266 start [ 1.804545]: AppleACPIButton:0x100000267 start [ 1.805234]: AppleACPIButton:0x10000026d start [ 1.814791]: ACPI: no ECDT [ 1.820989]: PMRD: PMTrace found PCI host bridge PCI0->AppleACPIPCI [ 1.825644]: ACPI lid state changed: 1 [ 2.349851]: Got boot device = IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/SAT0@17/AppleIntelPchSeriesAHCI/PRT0@0/IOAHCIDevice@0/AppleAHCIDiskDriver/IOAHCIBlockStorageDevice/IOBlockStorageDriver/Samsung SSD 850 EVO 250GB Media/IOGUIDPartitionScheme/Untitled 2@2/AppleAPFSContainerScheme/AppleAPFSMedia/AppleAPFSContainer/MacOS@4 [ 17.210745]: loadPrefs: IOService:/AppleACPIPlatformExpert/PCI0@0/AppleACPIPCI/IGPU@2-4c83-4b52-8f15feb28338bdce using new key[IGFB][LOG ][DISPLAY ] frameBufferNotificationCallback notification received on Fb 1 at time 17212174 [ 28.483833]: ACPI lid state query: 1 [ 1769.185593]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 1769.194484]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 1789.096701]: PMRD: kIOMessageSystemWillSleep[3] to com.apple.driver.AppleACPIPlatform [ 1789.099289]: PMRD: kIOMessageSystemCapabilityChange[23] to com.apple.driver.AppleACPIPlatform [ 1789.966757]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 1789.981415]: ACPI SLEEP [ 1789.985818]: ACPI switch to MemPool [ 1789.995635]: ACPI S3 WAKE [ 1790.019398]: AppleACPIPlatformPower Wake reason: PWRB XDCI (User) [ 1790.019402]: AppleACPIPlatformPower Wake reason: PWRB XDCI (User) [ 1850.413008]: PMRD: kIOMessageSystemWillPowerOn to com.apple.driver.AppleACPIPlatform [ 1850.418953]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 1850.435426]: PMRD: claimSystemWakeEvent(XHC, 0x1, AppleACPIPCI, 0x10000025f) aot 0 phase 0x27 add 1 [ 1852.485326]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 1852.495986]: PMRD: kIOMessageSystemHasPoweredOn to com.apple.driver.AppleACPIPlatform [ 3658.083119]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 3658.091949]: Sandbox: mediaremoted(89) allow iokit-get-properties class:IOAudioSelectorControl property:IOAudioControlSubTypeSandbox: mediaremoted(89) allow iokit-get-properties class:IOAudioLevelControl property:IOAudioControlSubTypePMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 3677.578144]: PMRD: kIOMessageSystemWillSleep[3] to com.apple.driver.AppleACPIPlatform [ 3677.580830]: PMRD: kIOMessageSystemCapabilityChange[23] to com.apple.driver.AppleACPIPlatform [ 3678.061321]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [ 3678.064953]: ACPI SLEEP [ 3678.068927]: ACPI switch to MemPool [ 3678.078798]: ACPI S3 WAKE [ 3678.103333]: AppleACPIPlatformPower Wake reason: RTC XDCI (Alarm) [ 3678.103336]: AppleACPIPlatformPower Wake reason: RTC XDCI (Alarm) [10872.153747]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [10872.159859]: PMRD: AppleACPIPCI: delay child notify [10872.159877]: PMRD: AppleACPIPCI: delay child notify [10872.171711]: PMRD: claimSystemWakeEvent(XHC, 0x1, AppleACPIPCI, 0x10000025f) aot 0 phase 0x27 add 1 [10874.211997]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [10925.786704]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [10926.260690]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [10926.264482]: ACPI SLEEP [10926.268568]: ACPI switch to MemPool [10926.278568]: ACPI S3 WAKE [10926.302924]: AppleACPIPlatformPower Wake reason: PWRB XDCI (User) [10926.302927]: AppleACPIPlatformPower Wake reason: PWRB XDCI (User) [11523.936151]: PMRD: kIOMessageSystemWillPowerOn to com.apple.driver.AppleACPIPlatform [11523.942248]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [11523.958705]: PMRD: claimSystemWakeEvent(XHC, 0x1, AppleACPIPCI, 0x10000025f) aot 0 phase 0x27 add 1 [11526.006829]: PMRD: kIOMessageSystemCapabilityChange[3] to com.apple.driver.AppleACPIPlatform [11526.013042]: PMRD: kIOMessageSystemHasPoweredOn to com.apple.driver.AppleACPIPlatform

zhen-zen commented 1 year ago

Just realized I might forgot something fundamental. What do you mean by "don't read fan" and what's expected?

mbarbierato commented 1 year ago

I mean the speed of the fans in the app is 0 and also in macfancontrol and also in other software Screenshot 2022-10-24 alle 13 56 30

zhen-zen commented 1 year ago

Does fan speed control work? The code is developed and confirmed working on X and T series, based on their EC layout. I'm not sure why L series broke when they have similar interface.

mbarbierato commented 1 year ago

No the fan speed control doesn't work , if I press the full button or move the slider doesn't change the speed

mbarbierato commented 1 year ago

I confirm that's work also in e series i tried in e570 and e580