search

zhengchuanpan / INCREASE

INCREASE: Inductive Graph Representation Learning for Spatio-Temporal Kriging
Apache License 2.0
13 stars 2 forks source link

Wrong testing setting #1

Open Sam1224 opened 1 year ago

Sam1224 commented 1 year ago

Hi, it seems that your testing setting is wrong. In utils.py (METR-LA), Line 86-92, both of inputs and ground truth only contain values of unknown roads, so the task is data reconstruction. However, in data kriging, we should use known roads to infer (and evaluate) unknown roads during testing.

Sam1224 commented 1 year ago

Hi, it seems that your testing setting is wrong. In utils.py (METR-LA), Line 86-92, both of inputs and ground truth only contain values of unknown roads, so the task is data reconstruction. However, in data kriging, we should use known roads to infer (and evaluate) unknown roads during testing.

It's interesting that your model could still work when I change the test setting to that of IGNNK :)