search

zhengqili / MegaDepth

Code of single-view depth prediction algorithm on Internet Photos described in "MegaDepth: Learning Single-View Depth Prediction from Internet Photos, Z. Li and N. Snavely, CVPR 2018".
MIT License
723 stars 169 forks source link

Loss functions #19

Open alexgkendall opened 5 years ago

alexgkendall commented 5 years ago

Awesome work, this is a fantastic concept. I had a question about the loss:

https://github.com/lixx2938/MegaDepth/blob/f1ffe4ca8b6c49e55e36259ac34909de6c90a27b/models/HG_model.py#L116

Why do you have a square root term here, this doesn't correspond to Eq. 2 in the paper? For the hyperparams you supply in the paper are they with this sqrt loss or the one from your paper?

It would also be great to see implementations of the gradient loss term too if you can.

Thanks!

zhangxgu commented 5 years ago

I also want to see the implementations of the three loss in paper...