search

zhengster / pe

0 stars 0 forks source link

For view doctor command in particular: inconsistent spacing schemes accepted by application #11

Open zhengster opened 2 years ago

zhengster commented 2 years ago

This refactor could be implemented similarly for the rest of the view commands (view patient, view medicine, etc.).

image.png

You could either 1) allow user to enter the command as long as any kind of spacing is present (at least one space separating "view" from "doctor"), or you could specify in the user guide that, as long as one space is present between "view" and "doctor," the input is valid (which is the case I believe you've chosen to handle).

nus-se-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Yes, it would have been better if there was a standard. However, it is unlikely that that a user will be adding or removing spacing between words of a defined command. The commands are clearly defined in the user guide. However I do agree that this could have been better implemented or explained in the UG.

This issue is similar to issue #365

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Application accepts whitespace in front of user command but does not allows accept whitespace in the middle

The application allows users to delete doctors using a command with too much whitespace at the front:

image.png

However, having whitespace in the middle is not always permitted.

image.png

Perhaps you could choose one standard to obey.

[original: nus-cs2113-AY2122S2/pe-interim#410] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Ye I do agree that there should be a standard to obey. However I think this is a low severity bug as users will not frequently use additional spacings between words in a given command. This bug only occurs in rare instances.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]