search

zhengster / pe

0 stars 0 forks source link

Inconsistent use of plural form between "update medicines" and "view medicine" #12

Open zhengster opened 2 years ago

zhengster commented 2 years ago

image.png

For consistency (and to make it clear to the user that there should be multiple medicines listed), consider refactoring the code such that both use the plural (i.e. "update medicines" and "view medicines.")

nus-pe-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

I agree that there could have been better usage of plural and singular forms for the commands. However this is a simple issue that does not cause great displeasure to the user or make the application difficult to use. Hence I believe this of severity.Low instead of Medium.

Furthermore the functionality of each command is explained clearly in the UserGuide hence there would not be any great displeasure caused to the user.

This is similar to the bug raised #363 that calls on the use of plural and singular commands.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Commands for viewing doctors, patients, medicines should probably be pluralized

image.png

The singular "doctor" in "view doctor" seems to invite the user to view a singular doctor instance, and it would therefore seem intuitive to write "view doctor /info [NRIC]." However, this command allows the user to view all doctors, and so it would likely be less confusing if the command was "view doctors" instead.

[original: nus-cs2113-AY2122S2/pe-interim#408] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Yes I agree that a better usage of plural and singular forms might be more intuitive. However the functionalities of these commands have been clearly explained in the UserGuide. I do not think this is an issue of Medium severity, there will be some occasions where it might hinder the user experience but however after reading the User Guide and having used the application this should not give any issues to the user. Hence I believe this is an issue of lower severity.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]