nus-pe-script
commented
2 years ago [IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Team's Response
We obviously cannot implement the same check as other input fields because this field is different from others. The closest one would be the check done for address, which accepts alphanumerics and a few commonly used special characters. However, for the current iteration of our application, it is for small clinics which are usually private. Hence, it is likely that each clinic have different medicine suppliers, in which the batch id could be different. Simplistic validation algorithm would only hinder the clinic administrator from inputting their preferred batch id that helps them to keep track of stocks easily. A more complex algorithm is clearly out of scope because it is low priority compared to the features delivered by V2.1, similar to how implementing a detection algorithm to indicate that "hi" typed in by the tester clearly is not a medicine name.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
I noticed that other commands have a check for whether invalid characters are included. For consistency, consider implementing the same check for the batch id for adding a medicine.