search

zhengster / pe

0 stars 0 forks source link

Consider allowing user to delete medicines (or doctors, etc.) based on information other than the Batch ID #15

Open zhengster opened 2 years ago

zhengster commented 2 years ago

image.png Currently, you can only delete a medicine based on the Batch ID. But for find-related commands, you implement it in such a way that you allow the user to find an object with any type of attribute, not just their NRIC/ID, etc.

image.png

For completeness (and if you have time), you can implement "delete" similarly.

soc-pe-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

I agree that it could be useful to delete via other attributes of an object. However, we chose to delete objects based on their unique identifying key. For example if i were to delete a doctor based on the name, there may be mutiple doctors with the same name. This will require the application to print a list of doctors with that particular name and reprompt the user to define which particular doctor he/she wants to remove.

Being a CLI app aimed at being efficient and easy for users who enjoy typing single line commands. It makes more sense that users are able to delete objects with a single statement rather than having to go through a series of steps to perform a simple deletion.

However this could be a useful functionality, if we were to extend the application to have a GUI. However that is not within the scope of this project.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]