zhengster / pe

0 stars 0 forks source link

Allowed to add a patient even when spacing does not conform to the specified command in the user guide #4

Open zhengster opened 2 years ago

zhengster commented 2 years ago

Similar to the spacing issue with adding a doctor, the user is allowed to add a patient with an input that does not completely conform to what is outlined in the user guide. image.png image.png

nus-se-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Similar to issue #359

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error should probably be thrown when the user doesn't space their commands correctly

Your UG specifies that the user input their "add doctor" command as follows: image.png

However, your implementation allows for spacing to occur. image.png

You could either fix this by specifying in the UG that lack of spaces are allowed, or you could fix the code itself to not accept improperly-spaced commands.


[original: nus-cs2113-AY2122S2/pe-interim#404] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

I believe that small issues like inconsistent spacing is common for any typist. Our app is built to recognise these minor human errors and give a better user experience. The implementation was intended to accept inputs even if there were minor spacing issues. We did'nt find the need to include this in the UserGuide itself as its not really a feature that the user has to take note of, its just there to make the user experience better.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]