zhengster / pe

0 stars 0 forks source link

Permitted to add a doctor with an invalid type of specialization #5

Open zhengster opened 2 years ago

zhengster commented 2 years ago

It's possible to add a doctor with a specialization that is not a valid medical career :)

Perhaps you could fix this by defining a pre-set list of valid medical occupations, and checking if the user added a doctor with a specialization in this list. image.png

nus-pe-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

And the reason why you can do that is we don't have an overall list of all types because we can't connect to the MOH website via the internet for all possible specializations. We thought of it that way for users to add in any specialization in any form even crazy ones like "Sheesol".

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]