zhengyuf / IMavatar

Official repository for CVPR 2022 paper: I M Avatar: Implicit Morphable Head Avatars from Videos
MIT License
633 stars 61 forks source link

coordinate system #11

Closed UestcJay closed 2 years ago

UestcJay commented 2 years ago

hi, yufeng In get_camera_params functions, the z is mul -1, I wonder if the camera and world coordinate system follow the OpenCV convention[right, down, forward]?

zhengyuf commented 2 years ago

Hey,

It probably doesn't follow OpenCV convention. The z is not forward, but backward. x and y are probably right and down, but I'm not sure... I just found a way that worked and I don't dare changing the camera system anymore.😂

Best, Yufeng

UestcJay commented 2 years ago

thanks for your reply! sorry to bother you again. why the fx mul -1 in optimize.py here

zhengyuf commented 2 years ago

It's also multiplied by -1 in the saved intrinsics, so we made sure that the main code and preprocessing code have the same camera transformations.

As for why, there is not really a good reason, I think I just followed NerFace which also multiplied fx with -1, and just kept using this.