nus-pe-bot
commented
12 months ago Team's Response
We believe this to be a duplicate of another bug. In that bug, it states that "I can add a new student with the same particulars as another student (see students 8 and 9) , and that should not be allowed as it is unlikely for students to have the same phone number, email, or telegram handle, as such the app should warn me if i mistakenly add duplicate particulars". The issue brought up here is that users are allowed to have the same phone number, email or telegram handle. Let us refer to the CS2103T website to see what constitutes a duplicate bug.
As shown in the image above, "Multiple buggy behaviors that are actually caused by the same defect and cannot be fixed independently (i.e., fixing one fixes the others automatically)" are considered duplicate bugs. As the issue of having duplicate persons is caused by our duplicate checker not checking email, telegram handles and phone numbers, fixing the checker would fix the this issue (as both issues are caused by the duplicate person checker not working). Thus, this is a duplicate.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Duplicate checking for student does not check particulars.
I can add a new student with the same particulars as another student (see students 8 and 9) , and that should not be allowed as it is unlikely for students to have the same phone number, email, or telegram handle, as such the app should warn me if i mistakenly add duplicate particulars.
[original: nus-cs2103-AY2324S1/pe-interim#1247] [original labels: type.FunctionalityBug severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
Thank you for alerting us on in this issue. While it is true that having repeated emails is a bug, we disagree with the severity level being medium.
As shown in the image above, a medium severity indicates that it "causes occasional inconvenience to some users". However, as Avengers only have to manage the same 6 to 8 students for the whole semester, it is not very likely for them to change their student details. Hence, it would be a stretch to say that it causes occasional inconvenience when for most users, they only need to input student details once. Moreover, this issue only happens if Avengers type a duplicate student detail, which is unlikely to happen frequently.
In addition, while it might seem that 2 different students cannot have the same student details, there might be cases where an Avenger might want to utilize another student's details.
For example, personally as an Avenger, I had a student who did not have a telegram account. As such, I would instead message his friend whenever I wanted to contact him. That friend happened to be in the same studio group as him. As this student happened to be from overseas, he was also using a foreign number. As it would be more costly to call his foreign number in Singapore, I would call his friend if I had any urgent information to tell him. Hence, due to such personal experiences, our team has decided to give users the flexibility to insert duplicate student details to help account for such cases. To ignore such edge cases would be a disservice to our users.
Warmest Regards,
Team F.A.K.E.J.A.R.V.I.S.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Two users can have the exact same phone numbers, telegram handles and emails. While this can be true for other attributes like a home address for brothers for example, this is untrue for unique identifiers like phone numbers, telegram handles and email accounts which are unique to an individual student. The app would be much more robust if the duplicate entry validation takes this into account