search

zhengyup / pe

0 stars 0 forks source link

Better duplicate validation : Checking names more closely #7

Open zhengyup opened 1 year ago

zhengyup commented 1 year ago

Though the app checks for duplicates using duplicate names, it allows for two students of the same name but with an extra space in between. This is an edge case that could undermine the robustness of the application. John doe vs John Doe (2 spaces) Screenshot 2023-11-17 at 4.39.10 PM.png

nus-se-bot commented 12 months ago

Team's Response

We believe this is a duplicate bug. For the bug that we believe this to be a duplicate of, the 2nd step to replicate states "add n/John Doe p/98765432 e/johnd@u.nus.edu th/johnny01 gt/RA1:0 | RA2:0 |MidTerms:0 | Finals:0 | PE:0 (Put an extra space between John and Doe here, as the user can accidentally put an extra space)". This is the same as what is being mentioned in this bug.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

I am able to add the same person multiple times, by mistake (Not enough duplicate detection)

image.png

Under "feature flaws: bugs related to duplicate detection"

Steps to recreate:

  1. add n/John Doe p/98765432 e/johnd@u.nus.edu th/johnny01 gt/RA1:0 | RA2:0 |MidTerms:0 | Finals:0 | PE:0
  2. add n/John Doe p/98765432 e/johnd@u.nus.edu th/johnny01 gt/RA1:0 | RA2:0 |MidTerms:0 | Finals:0 | PE:0 (Put an extra space between John and Doe here, as the user can accidentally put an extra space)
  3. add n/john doe p/98765432 e/johnd@u.nus.edu th/johnny01 gt/RA1:0 | RA2:0 |MidTerms:0 | Finals:0 | PE:0 (John Doe and john doe are likely to be the same person)

Low due to minor inconvenience and very minimal appearance

[original: nus-cs2103-AY2324S1/pe-interim#4320] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the feedback! Our team agrees with your assessment of this bug. Good catch!

Warmest Regards,

Team F.A.K.E.J.A.R.V.I.S.

logofj (2).png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]