search

zhenyajiang / jupiter-eclipse-plugin

Automatically exported from code.google.com/p/jupiter-eclipse-plugin
0 stars 0 forks source link

Review table view out of sync with source code #20

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The Review Table list jumps to incorrect item upon double click on item or
upon 'clicking in' or 'selecting text in' the source related to that item.

We are consistantly seeing an issue where we double click on a defect in
the review table (or right-click and select goto).  The correct place in
the code is found.  However, the behaviour of the review table list is
erradic.  It jumps to an unrelated item in the list with the same line
number.  This happens sometimes upon double clicking and other times when
we click in the source file that the item refers to.  Other times, it seems
to happen when we select text in the source file that the item refers to.

In any case, this is a huge problem.  First, it gets very confusing what
item we left off on.  Second, it could lead to assigning a resolution to
the wrong item.  The item it incorrectly jumped to may have been a valid
defect while the one we were reviewing was deemed invalid.  If we didn't
realize that the jump in the list had occurred, we would end up marking a
valid defect as invalid and then not fixing it.

After much testing, it appears that the list jumps to the first occurrence
of that line number in the list, regardless of whether or not it is the
right item or even in the same file.  I'm not sure why the list should be
jumping at all.  I'd prefer the list remain unchanged rather than the item
jumping to the top.  However, if it must jump, jumping to the wrong item is
a huge problem for the reasons already mentioned.

Original issue reported on code.google.com by hongb...@gmail.com on 21 Feb 2008 at 7:20

GoogleCodeExporter commented 8 years ago 
This issue is a partial duplicate of Issue 17. 
http://code.google.com/p/jupiter-eclipse-plugin/issues/detail?id=17

I have already fixed the double-clicking on an issue in the review table.  The 
fix is
in revision 79 
(http://code.google.com/p/jupiter-eclipse-plugin/source/detail?r=79).
 The code that is commented out fixes the problem.  I will be cleaning it up shortly.

Can you check out the latest version of Jupiter and test this?  Mark this as a
duplicate if it fixes the issue.

Original comment by jsakuda on 21 Feb 2008 at 6:00

GoogleCodeExporter commented 8 years ago 
I believe this issue no longer exists.  Re-open if needed.

Original comment by jsakuda on 17 Aug 2008 at 11:24