Project Feedback - Githubissues

zhezixi / MI-449-SS18-740-html-multiple-pages-T_njfg

0 stars 0 forks source link

Project Feedback #1

Open zhezixi opened 6 years ago

zhezixi commented 6 years ago

Build a fansite for books, movies, video games, or anything else

@KatieMFritz Can you take a look at this? It's hosted here and meets the following criteria:

[x] None of the routes on the website end with .html
[x] A homepage exists, where the purpose of the site is explained
[x] A "list page" exists that lists your top 3 favorite of this thing (e.g. /pokemon) -- each list item should link to the corresponding page for that favorite, detailed below
[x] For each of your favorites, a page exists to display more information about it (e.g. /pokemon/bulbasaur) -- we want to make sure you practice multiple levels of nested routes
[x] Every page includes links to the homepage and list page (although pages do not have to link to themselves)

egillespie commented 6 years ago

Hi @zhezixi, the link on your homepage is broken. It's pointing to /List instead of /list. I also see that your favorites directories are at the same level as list. Would you mind moving the three directories (,, and `) inside yourlist` directory and updating the links so they all point at valid locations?

Comment back when you're ready for me to take another look! 👾

zhezixi commented 6 years ago

Just fixed the pages. Can you check it for me? Thanks!

egillespie commented 6 years ago

I see you replaced a lot of links to /List, but it appears that the link in /index.html is still pointing there. Can you update that one, too?

Thanks! 🚀

zhezixi commented 6 years ago

Sorry I forgot to change that. I just fixed it. Thanks!

egillespie commented 6 years ago

Thanks! I really like the multiple levels of nested routes that you've used in your project — it really shows that you understand the concepts in this lesson! 🤘

I see a couple spots where your code can still be improved:

1. A few more validator errors

There are still some W3 validator errors on your list page. Would you mind taking care of these? All the other pages pass validation.

2. Broken link on DJI Phantom 4 page

There's one last broken link on your DJI Phantom 4 page. Would you mind fixing this?

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 📸

zhezixi commented 6 years ago

Just fixed them. Is it looks right now?

egillespie commented 6 years ago

Yep, you nailed it! Good job! 💥 :shipit: