zhezixi / MI-449-SS18-740-js-server-intro-jtrO3q

0 stars 0 forks source link

Project Feedback #1

Open zhezixi opened 6 years ago

zhezixi commented 6 years ago

Build a simple web server that handles any URL

@KatieMFritz Can you take a look at this? It's hosted here and meets the following criteria:

egillespie commented 6 years ago

Hi @zhezixi, this is great! Your homepage, cuteness page, and error pages are all working flawlessly. Nice! 🎉

I have one recommendation to improve your random joke page:

Use === to compare values in an if condition

Your if conditions are using the assignment (=) operator instead of the comparison (===) operator:

if (randomNumber = 1)
else if (randomNumber = 2)

This is resulting in the same joke displaying every time I visit the page. Would you mind switching those assignment operators to comparison operators so different jokes show up?


After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🍿

zhezixi commented 6 years ago

Just fixed!

egillespie commented 6 years ago

Perfect! I can see a different random joke each time I refresh the page now. Good work! 🤘 :shipit: