zhiburt
commented
1 year ago Hi @stefan-mysten
You have touched a hard topic :)
In summary:
- because currently it's not clear how to index recursive
json, you can't do changes to the content. (though maybe we shall). - because currently it's not clear how to generally do overall width control it's not implemented (though maybe we shall; see bellow).
My main struggle is that I have a table where my first column is the header for each row, and 2nd column has the values for each row. One row has 360 characters, and I'd like to wrap it (maybe 80 chars per line?), because the table gets really weird.
Could you provide your table?
Cause sounds like it's has relatively simple structure and you might better just really convert it into tables::Table.
I think we could provide such a function for a not recursive json (unfortunately yet it's not implemented, but could be a good first issue).
- is there a way to transform a
JsonTabletype into atabled::Tabletype?
No.
Though it would be possible to convert it into PoolTable (it is not yet in implemented; but it also does not support Wrap).
- how can one taylor the style of a
JsonTableusing the standard methods fromTablesuch as Width, Row, Wrap, etc. Doing something like: table.with(Width::wrap(120)); where table is aJsonTableyields this errorthe trait `TableOption<EmptyRecords, CompleteDimension<'static>, ColoredConfig>` is not implemented for `tabled::settings::width::Wrap`
You can't. The main reason why it was not implemented is because it's not clear how to do that. I mean some people would like to do the width control differently so it was not implemented.
I am not sure if you're aware of https://github.com/nushell/nushell/. But bellow I've provide an example to do something similar.
The example is a bit long and quite complex but.... it does it's job I do think.
You can just copy&paste and try with your json.
Let me know what do you think.
use serde_json::Value;
use tabled::{
grid::dimension::{DimensionPriority, PoolTableDimension},
grid::util::string::{string_width, string_width_multiline},
settings::style::Style,
settings::width::Wrap,
tables::{PoolTable, TableValue},
Table,
};
fn main() {
let json = serde_json::json!({
"key1": "value1",
"key2": {
"key1": 123,
"key2": [1, 2, 3, 4, 5],
},
"key3": [
{"key": 123.3},
2,
"asd"
],
});
let table = build_table(json, 20);
println!("{table}");
}
fn build_table(json: Value, width: usize) -> PoolTable {
let mut value = json_to_table(json);
truncate_table_value(&mut value, true, width);
let mut table = PoolTable::from(value);
table.with(PoolTableDimension::new(
DimensionPriority::Last,
DimensionPriority::Last,
));
table.with(Style::modern());
table
}
fn json_to_table(json: Value) -> TableValue {
match json {
Value::Array(list) => {
let values = list.into_iter().map(|value| json_to_table(value)).collect();
TableValue::Row(values)
}
Value::Object(map) => {
let values = map
.into_iter()
.map(|(key, value)| {
let key = TableValue::Cell(key);
let value = json_to_table(value);
TableValue::Row(vec![key, value])
})
.collect();
TableValue::Column(values)
}
value => TableValue::Cell(value.to_string()),
}
}
fn truncate_table_value(
value: &mut TableValue,
has_vertical: bool,
available: usize,
) -> Option<usize> {
const MIN_CONTENT_WIDTH: usize = 10;
const TRUNCATE_CELL_WIDTH: usize = 3;
const PAD: usize = 2;
match value {
TableValue::Row(row) => {
if row.is_empty() {
return Some(PAD);
}
if row.len() == 1 {
return truncate_table_value(&mut row[0], has_vertical, available);
}
let count_cells = row.len();
let mut row_width = 0;
let mut i = 0;
let mut last_used_width = 0;
for cell in row.iter_mut() {
let vertical = (has_vertical && i + 1 != count_cells) as usize;
if available < row_width + vertical {
break;
}
let available = available - row_width - vertical;
let width = match truncate_table_value(cell, has_vertical, available) {
Some(width) => width,
None => break,
};
row_width += width + vertical;
last_used_width = row_width;
i += 1;
}
if i == row.len() {
return Some(row_width);
}
if i == 0 {
if available >= PAD + TRUNCATE_CELL_WIDTH {
*value = TableValue::Cell(String::from("..."));
return Some(PAD + TRUNCATE_CELL_WIDTH);
} else {
return None;
}
}
let available = available - row_width;
let has_space_empty_cell = available >= PAD + TRUNCATE_CELL_WIDTH;
if has_space_empty_cell {
row[i] = TableValue::Cell(String::from("..."));
row.truncate(i + 1);
row_width += PAD + TRUNCATE_CELL_WIDTH;
} else if i == 0 {
return None;
} else {
row[i - 1] = TableValue::Cell(String::from("..."));
row.truncate(i);
row_width -= last_used_width;
row_width += PAD + TRUNCATE_CELL_WIDTH;
}
Some(row_width)
}
TableValue::Column(column) => {
let mut max_width = PAD;
for cell in column.iter_mut() {
let width = truncate_table_value(cell, has_vertical, available)?;
max_width = std::cmp::max(max_width, width);
}
Some(max_width)
}
TableValue::Cell(text) => {
if available <= PAD {
return None;
}
let available = available - PAD;
let width = string_width(text);
if width > available {
if available > MIN_CONTENT_WIDTH {
*text = string_wrap(text, available);
Some(available + PAD)
} else if available >= 3 {
*text = String::from("...");
Some(3 + PAD)
} else {
// situation where we have too little space
None
}
} else {
Some(width + PAD)
}
}
}
}
fn increase_width(text: &str, width: usize) -> String {
text.lines()
.map(|line| {
let line_width = string_width(line);
let rest_width = width - line_width;
let mut line = line.to_string();
line.extend((0..rest_width).map(|_| ' '));
line
})
.collect::<Vec<_>>()
.join("\n")
}
fn string_wrap(text: &str, width: usize) -> String {
Wrap::wrap_text(text, width, false)
}┌──────┬────────────┐
│ key1 │ "value1" │
├──────┼──────┬─────┤
│ key2 │ key1 │ 123 │
│ ├──────┼─────┤
│ │ key2 │ ... │
├──────┼──────┴─────┤
│ key3 │ ... │
└──────┴────────────┘
┌──────┬────────────────────────┐
│ key1 │ "value1" │
├──────┼──────┬─────────────────┤
│ key2 │ key1 │ 123 │
│ ├──────┼───┬───┬───┬─────┤
│ │ key2 │ 1 │ 2 │ 3 │ ... │
├──────┼─────┬┴───┴──┬┴──┬┴─────┤
│ key3 │ key │ 123.3 │ 2 │ ... │
└──────┴─────┴───────┴───┴──────┘
stefan-mysten
Hi @zhiburt
Love the library, this is really a fantastic work that you and others have done.
I have a few questions on how to taylor the style of JSON tables using the json-table crate.
JsonTabletype into atabled::Tabletype?JsonTableusing the standard methods fromTablesuch as Width, Row, Wrap, etc. Doing something like: table.with(Width::wrap(120)); where table is aJsonTableyields this errorMy main struggle is that I have a table where my first column is the header for each row, and 2nd column has the values for each row. One row has 360 characters, and I'd like to wrap it (maybe 80 chars per line?), because the table gets really weird.
Thanks in advance!