search

zhiburt / tabled

An easy to use library for pretty print tables of Rust structs and enums.
MIT License
1.94k stars 77 forks source link

Fix clippy and tests fail due to simple problems #415

Closed strange-dv closed 1 month ago

strange-dv commented 2 months ago

Closes #414

This PR fixes small issues that cause CI to fail due to failing tests and cargo clippy

Testing

Local testing using cargo test --workspace --no-fail-fast --all-features and cargo clippy --all --all-targets --all-features

zhiburt commented 2 months ago

Hmmmm

I did not realized it since today. The errors comes from https://github.com/unicode-rs/unicode-width/issues/65

If on unicode-width="0.2.11" it all works but on newest its not.


failures:
    core::table_test::derived::table_emojie_multiline
    settings::render_settings::tab_isnot_handled_by_default_test
failures:
    util::string::tests::strip_test
failures:
    grid::format_configuration::tabs_arent_handled
    grid::render::doesnt_render_return_carige_0
    grid::render::doesnt_render_return_carige_1
    grid::render::hieroglyph_handling_2
zhiburt commented 2 months ago

I think we need put some thinking to how to resolve it. Either to force 0.2.11 usage. Or adjust used logic, accordingly.

zhiburt commented 1 month ago

As far as I think about it nowadays \ Could you make a 3 changes in Cargo.tomls (papergrid/Cargo.toml, tabled/Cargo.toml, testing_table/Cargo.toml)

-unicode-width = "0.1"
+unicode-width = "=0.1.11"

Once you do the failed tests must be fixed on its own. And we could land it.

zhiburt commented 1 month ago

OK seems good to me :100:

Thanks @Alexdelia for review Thanks for commitment @strange-dv

Have a good week; Take care