search

zhiburt / tabled

An easy to use library for pretty print tables of Rust structs and enums.
MIT License
1.94k stars 77 forks source link

Improve some formulations in README.md #417

Closed xeruf closed 1 month ago

xeruf commented 1 month ago

Clarifications that seemed sensible as I read through.

zhiburt commented 1 month ago

And I wonder what do you think is the README/docs OK overall?

Alexdelia commented 1 month ago

I really like the changes

@xeruf thanks for them :smile:

Alexdelia commented 1 month ago

And I wonder what do you think is the README/docs OK overall?

imo, quite above average

there are lot of example and learning by example is one of the best way to learn (my opinion)

zhiburt commented 1 month ago

there are lot of example

Recently I've started to think that a lot of examples could be more real and easier to grasp. As many of them are using dumb data like [1, 2, 3] "not usefull" text etc and not essential settings.

There are a few good examples but many are not as good as they could be that's what I am saying.

I wonder if making it like using real data being more useful. I am writing it just in case you @Alexdelia wanted to take a look at it and maybe do improve some of them.

And don't you want to fork from this PR and open new so we could merge it? @xeruf seems to a bit busy but I think it'd be necessary to save his commitment.

Alexdelia commented 1 month ago

I wonder if making it like using real data being more useful. I am writing it just in case you @Alexdelia wanted to take a look at it and maybe do improve some of them.

And don't you want to fork from this PR and open new so we could merge it? @xeruf seems to a bit busy but I think it'd be necessary to save his commitment.

I'm a lead dev and got work today (unsure about how busy later this week). But I do keep that in mind for if/when time comes.

zhiburt commented 1 month ago

So I did merged it 3c85d08d29c49d6c884d67833021bf893d678f00 Sorry @Alexdelia I wasnot able to find your emal so Co-Author hook didn't worked for you.

But anyhow

Thanks a lot Take care.

Alexdelia commented 1 month ago

So I did merged it 3c85d08 Sorry @Alexdelia I wasnot able to find your emal so Co-Author hook didn't worked for you.

no problem, I did not contribute much code

but thanks for the effort anyway

FYI, my email: adelille@student.42.fr

xeruf commented 1 month ago

Thanks, indeed got caught up in other things! Wanted to replace preconfigured by included, apparently some characters got lost there :sweat_smile: