zhigang1992 / react-native-jsonschema-form

react native implementation of https://github.com/rjsf-team/react-jsonschema-form
29 stars 20 forks source link

refactor!: update project sructure and dependencies #2

Closed ngort01 closed 4 years ago

ngort01 commented 4 years ago

This updates the project structure and tooling and also now uses @rjsf/core instead of react-jsonschema-form. So the packege can be used like all the other themenig packages .

Additional changes:

zhigang1992 commented 4 years ago

@ngort01 are you able to get example app to work?

I'm experiencing crash on launch and missing font of Roboto when using iOS simulator?

We should properly not be using Roboto since it might be available in the app bundle?

ngort01 commented 4 years ago

@zhigang1992 I'll remove the Roboto font. The example works for me on Windows + Android. I don't have a Mac here to try it on on iOS. Does it scrash because of the missing Roboto Font or is this just an additional error?

zhigang1992 commented 4 years ago

@ngort01 there were additional errors in the Xcode. I can look more into that a bit later.

zhigang1992 commented 4 years ago

Screen Shot 2020-07-14 at 4 51 24 PM

This was the first one, I removed FontFamily: ''

And then

Screen Shot 2020-07-14 at 4 55 12 PM

Upgraded Flipper version solved that

And then

Screen Shot 2020-07-14 at 5 00 48 PM

It works

And I've released v2.0.0 with these changes. 💯

ngort01 commented 4 years ago

@zhigang1992 cool!

There's still this open issue. Maybe we can get this package there

zhigang1992 commented 4 years ago

Ah right, I completely forget about that.

I not against moving it there. Just not have the time to craft a proper PR for it.

You can take on that if you have some time.

ngort01 commented 4 years ago

Okay, maybe I'll find some time to do it

firrae commented 2 years ago

Any update on that issue? This might be exactly what I need for my application. While I'm fine using a separate package, getting it included in main somehow would be great overall.