search

zhiguowang / BiMPM

BiMPM: Bilateral Multi-Perspective Matching for Natural Language Sentences
Apache License 2.0
438 stars 150 forks source link

BiMPM implementation in AllenNLP #48

Open hzeng-otterai opened 6 years ago

hzeng-otterai commented 6 years ago

@zhiguowang Thanks a lot for publishing the algorithm and code of BiMPM. I am implementing the BiMPM algorithm in the AllenNLP library so that more people could experiment and benefit from this algorithm. Please check the PR https://github.com/allenai/allennlp/pull/1594 for the re-implementation. It is based on your paper as well as the code here, and also can reproduce most of the results you described in the paper. Please help to review the code and let me know if you have any comments and suggestions about the PR. Thanks!

zhiguowang commented 6 years ago

Hi Handsome,

Thanks very much for you hard work. I'm very glad to help you to review the code. However, I will be very busy in the following weeks. I will definitely review the code when I'm free.

Best, Zhiguo

On Thu, Aug 9, 2018 at 2:34 PM, Handsome Zebra notifications@github.com wrote:

@zhiguowang https://github.com/zhiguowang Thanks a lot for publishing the algorithm and code of BiMPM. I am implementing the BiMPM algorithm in the AllenNLP library so that more people could experiment and benefit from this algorithm. Please check the PR allenai/allennlp#1594 https://github.com/allenai/allennlp/pull/1594 for the re-implementation. It is based on your paper as well as the code here, and also can reproduce most of the results you described in the paper. Please help to review the code and let me know if you have any comments and suggestions about the PR. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zhiguowang/BiMPM/issues/48, or mute the thread https://github.com/notifications/unsubscribe-auth/AYEV-V1fpD2IVdRsOBWEgdxb7oiEJmfNks5uPICpgaJpZM4V2Mut .