zhihuizhiming / neatx

Automatically exported from code.google.com/p/neatx
0 stars 0 forks source link

Fedora /usr/share/doc/neatx/neatx.conf.example needs /usr/bin/nc for netcat #41

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
On Fedora, netcat is /bin/nc .  In the RPM build, the line

#netcat-path = /bin/netcat

should be uncommented by default and should be

netcat-path = /bin/nc

Original issue reported on code.google.com by luke.hutch on 20 Jan 2010 at 7:20

GoogleCodeExporter commented 8 years ago
Sorry, that should be /usr/bin/nc not /bin/nc .

Original comment by luke.hutch on 20 Jan 2010 at 7:25

GoogleCodeExporter commented 8 years ago
(Sorry, looks like I don't have permissions to update the title of this issue, 
it still 
says /bin/nc which is incorrect)

Original comment by luke.hutch on 20 Jan 2010 at 7:39

GoogleCodeExporter commented 8 years ago
(Fixing the title) That's not really the correct way to fix things. Ideally, the
fedora build process would apply the following patch, i don't know how to make 
that
happen cleanly though:

diff --git a/doc/neatx.conf.example b/doc/neatx.conf.example
index aedd14e..c09e9d9 100644
--- a/doc/neatx.conf.example
+++ b/doc/neatx.conf.example
@@ -22,7 +22,7 @@ nx-protocol-version = 3.3.0

 ## Command Paths
 #bash-path = /bin/bash
-#netcat-path = /bin/netcat
+#netcat-path = /usr/bin/nc
 #xrdb-path = /usr/bin/xrdb
 #su-path = /bin/su
 #ssh-path = /usr/bin/ssh
diff --git a/lib/constants.py b/lib/constants.py
index 59a5cb0..eb86b0b 100644
--- a/lib/constants.py
+++ b/lib/constants.py
@@ -27,7 +27,7 @@ from neatx import _autoconf

 SYSLOG_ADDRESS = "/dev/log"
 BASH = "/bin/bash"
-NETCAT = "/bin/netcat"
+NETCAT = "/usr/bin/nc"
 XRDB = "/usr/bin/xrdb"
 SU = "/bin/su"
 SSH = "/usr/bin/ssh"

Original comment by kormat on 24 Jan 2010 at 3:56

GoogleCodeExporter commented 8 years ago
I'm definitely not an expert on RPM but the specfile has direct support for 
applying 
patches.  There is a description here: 
http://bradthemad.org/tech/notes/patching_rpms.php

Original comment by luke.hutch on 24 Jan 2010 at 5:27

GoogleCodeExporter commented 8 years ago
Alright, i've figured out how to do this, tested it on fedora 10/11/12, patch 
out for 
review.

Original comment by kormat on 9 Feb 2010 at 8:41

GoogleCodeExporter commented 8 years ago
Great, thank you kormat!  I put a request into the RedHat bugzilla to have the 
RPM 
included in Fedora, I hope someone picks it up as the maintainer.

Original comment by luke.hutch on 9 Feb 2010 at 8:44

GoogleCodeExporter commented 8 years ago
Fixed in http://code.google.com/p/neatx/source/detail?r=53 , merging with 
duplicate 
issue

Original comment by kormat on 12 Feb 2010 at 11:48