search

zhikaiong2001 / pe

0 stars 0 forks source link

User Guide does not explicitly specify what fields must be unique when adding a new person #5

Open zhikaiong2001 opened 6 months ago

zhikaiong2001 commented 6 months ago

Capture3.PNG The userguide shows the above, but does not explicitly state which fields must be unique. This could mislead the user into thinking that the phone number/email address must be unique instead of the name since that would seem more natural, as opposed to your app's design of having a unique name.

soc-pe-bot commented 5 months ago

Team's Response

In #5003, we had a similar issue that we did not tell the users which field was exactly the same, that prevented them from adding the new contact. This bug falls under the feature flaw as well, as it is a result of not considering the feature flaw of not specifying to the users which fields must be unique.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

More specific error message

Currently, if i try to add a contact with the same name as an existing contact, the app rejects it. Capture.PNG As seen from this image, since David already exists, I cannot add another David. The app then prompts that a contact with the same contact details already exists. I think the error message can be more specific as to which part of the contact details(the name) already exists.

[original: nus-cs2103-AY2324S2/pe-interim#4579] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We would like to clarify that this is actually not a functionality bug, since it doesn't fall into the category of "does not work as expected".

However, we still acknowledge it is a bug, but more of a feature flaw since as you mentioned, the error message could be more specific to help the user understand.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]