search

zhikaiong2001 / pe

0 stars 0 forks source link

Serquence diagram would be clearer if it shows one more layer #9

Open zhikaiong2001 opened 6 months ago

zhikaiong2001 commented 6 months ago

Capture.PNG For your application, the execution of the remove command would go through one more layer, which is the RemoveConfirmation whereby the user has to type yes or no after executing remove 1, so I think it would be clearer if the RemoveConfirmation object was included in the sequence diagram

nus-pe-script commented 5 months ago

Team's Response

RemoveCommand and RemoveConfirmation are actually two separately parsed commands. RemoveConfirmation is independently parsed in the AddressBookParser, and they are 2 independent objects created. Furthermore, this sequence diagram is almost immediately followed by the sequence diagram for RemoveConfirmation for clarity.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]