zhing22 / pe

0 stars 0 forks source link

Model component diagram #10

Open zhing22 opened 2 years ago

zhing22 commented 2 years ago

lack of multiplicity for name, phoneNumber, email and passport number Screenshot 2021-11-12 at 5.21.24 PM.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Model diagram lacking multiplicity - [DG]

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


image.png

No multiplicity is provided for Name, PassportNumber, RoomNumber and Email, yet multiplicity is provided for Tag and ChargeablesUsed.

This lack of detail and specification can leave developers confused when trying to understand your Model diagram, especially since multiplicity cannot be assumed.

Similarly, multiplicities are also not provided here

image.png


[original: nus-cs2103-AY2122S1/pe-interim#2830] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your time and effort in writing this bug report.

As mentioned in the textbook, multiplicities can be omitted, as long as it does not affect the understanding of the reader. The naming of the classes are also rather intuitive. Naturally, a guest would only have one name, one passport number, and so on..

I believe the issue here is that the multiplicities are not standardized, but we doubt that the omitting of the multiplicities would result in such misunderstanding and confusion for the reader. Thus, we feel that this should be reduced to low.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]