Closed ngavalas closed 7 years ago
cc @KlausTrainer
@ngavalas Test fails are due to old Node.js versions fail to compile some dependencies used in test code. I will fix this later.
Duh! Thanks for the heads-up and submitting the fix, @ngavalas!
Yeah, I saw the same test failures locally on OS X and didn't think it was related to this commit. I think this is safe to merge now, but it's up to you.
There is a bug in the pull request in https://github.com/zhipeng-jia/snappyjs/pull/1 that makes
Uint8Array
compression completely fail in the browser. Trying to compressUint8Array
falls through to theBuffer
case andBuffer
is only defined in node, so it throws. This fixes the bug and letsUint8Array
compression succeed and return the correct type.