search

zhiyi12345 / pe

0 stars 0 forks source link

Wrong error message displayed for numbers that is not within the index size #4

Open zhiyi12345 opened 4 days ago

zhiyi12345 commented 4 days ago


video:https://raw.githubusercontent.com/zhiyi12345/pe/main/files/9f5cb04f-c633-4759-aaef-366cd04bcdf3.mov When I delete a index that is out of range of the patient limit, for instant 10 when I only have 8 person, I will get an invalid index error message. However, when try to delete an index that is very large and obviously not within the range of the patient limit, instead of getting the same error message, the error messages changed to invalid format.

Workaround this error is due to the limit of int, it will be better to include it under constraints or mention it in the UG

nus-pe-bot commented 21 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response


video:https://raw.githubusercontent.com/nus-cs2103-AY2425S1/pe/master/files/94b6d5bc-36ee-4e2e-90b8-5a206ad121a3.mp4

As can be seen from the video above, this issue is likely to be caused by the 32-bit integer limit. While valid, this is a rather trivial issue because in reality one is most likely not going to have more than 2147483647 gaming contacts.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]