zhjohnchan / R2GenCMN

[ACL-2021] The official implementation of Cross-modal Memory Networks for Radiology Report Generation.
Apache License 2.0
77 stars 7 forks source link

About report_masks? #5

Closed caodoanh2001 closed 1 year ago

caodoanh2001 commented 1 year ago

Hello,

Thank you for your good work. However, I saw that you use the key "report_masks" from annotation dictionary, but it is not included in file "annotation.json" you provided. Even you used "report_masks" to compute loss function, you have no explanation for this.

Hope receive your response soon, Best.

douseful commented 1 year ago

report_masks are defined here: https://github.com/zhjohnchan/R2GenCMN/blob/3a995dc7744222187c0a927e8b44a555191bf592/modules/datasets.py#L19-L21 then https://github.com/zhjohnchan/R2GenCMN/blob/3a995dc7744222187c0a927e8b44a555191bf592/modules/datasets.py#L55-L57

zhjohnchan commented 1 year ago

Hi @douseful and @caodoanh2001,

Thank you so much for the explanation @douseful!

Best, Zhihong